-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive @@iterator for PluginArray/MimeTypeArray #6368
Conversation
@@iterator is [implicitly defined by indexed property getters](https://heycam.github.io/webidl/#ref-for-dfn-indexed-property-getter%E2%91%A6). Since there is no other way to define it exclusively, this restores some methods back to getters.
If Chrome is in fact removing cc @mfreed7 |
It's probably simplest to merge this to get us back to "no behavior changes for Firefox" and "minimal compat risk for Chrome". Even if we leave it in forever it's not a big deal; the gain from removing this is much less than the gain from removing |
@@ -117129,7 +117129,7 @@ interface <dfn data-x="dom-Plugin">Plugin</dfn> { | |||
readonly attribute undefined <span data-x="dom-Plugin-description">description</span>; | |||
readonly attribute undefined <span data-x="dom-Plugin-filename">filename</span>; | |||
readonly attribute undefined <span data-x="dom-Plugin-length">length</span>; | |||
undefined <span data-x="dom-Plugin-item">item</span>(unsigned long index); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this change is especially strange since instances of Plugin
cannot be instantiated. So this really only is detectable via Symbol.iterator in Plugin.prototype
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do hope we can remove Plugin
and MimeType
, seems likely given iOS.
I think I'm ok trying to remove |
@@iterator is implicitly defined by indexed property getters. Since there is no other way to define it exclusively, this restores some methods back to getters.
(See WHATWG Working Mode: Changes for more details.)
/obsolete.html ( diff )