Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand <details> for find-in-page and element fragments #6466

Merged
merged 18 commits into from
Aug 6, 2021
Merged

Expand <details> for find-in-page and element fragments #6466

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6150b78
Expand <details> for find-in-page and element fragments
josepharhar Feb 18, 2021
2ff7386
Rewrite find-in-page section and revert rendering section
josepharhar Mar 9, 2021
738da4b
Add ancestor details revealing algorithm
josepharhar Apr 7, 2021
21ee9bd
Adjust algorithms
josepharhar Apr 29, 2021
0e4b44a
Add <var>s and <span>s, use list for conditional
josepharhar May 6, 2021
60e8e57
Fixed </p> after </li>
josepharhar May 6, 2021
14f3eb5
Merge 3 months of commits from main
josepharhar May 7, 2021
f07c1fb
More formatting
josepharhar May 7, 2021
96b233d
Final nit
domenic May 7, 2021
b2dc599
Address comments
josepharhar May 11, 2021
a3dadcf
Add case for open attribute already set
josepharhar May 19, 2021
1717601
Added content-visibility:hidden
josepharhar Jun 9, 2021
b6bd17a
must -> expected to
josepharhar Jun 16, 2021
3cdc0be
Use style attribute
josepharhar Jun 16, 2021
07f4bd8
Add missing </span>
josepharhar Jun 16, 2021
5d1e8c7
Add <code> to style attribute
josepharhar Jun 17, 2021
295912a
Add flat tree
josepharhar Jul 28, 2021
4054db9
Editorial tweaks
domenic Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75340,6 +75340,13 @@ body { display:none }
can navigate through the <span data-x="fip-matches">matches</span> by advancing the <span
data-x="fip-active-match">active match</span> using the <span>find-in-page interface</span>.</p>

<p>When a find-in-page search encounters a <code>details</code> element which is not <code
data-x="attr-details-open">open</code>, it should search the hidden contents inside the
domenic marked this conversation as resolved.
Show resolved Hide resolved
<code>details</code> element as if it were open, but without adding the <code
data-x="attr-details-open">open</code> attribute. If a match inside the closed contents becomes
the <dfn dat-x="fip-active-match">active match</dfn>, the details element as well as any other
details elements in the ancestor chain containing the match should be opened.
domenic marked this conversation as resolved.
Show resolved Hide resolved

<p class="XXX"><a href="https://github.com/whatwg/html/issues/3539">Issue #3539</a> tracks
standardizing how <span>find-in-page</span> underlies the currently-unspecified <code
data-x="">window.find()</code> API.</p>
Expand Down Expand Up @@ -86015,6 +86022,11 @@ new PaymentRequest(&hellip;); // Allowed to use
<li><p>Set the <code>Document</code>'s <span>target element</span> to
<var>target</var>.</p></li>

<li><p>If there are one or more <code>details</code> elements in the ancestor chain of
<var>target</var> which are not <code data-x="attr-details-open">open</code>, then <code
data-x"attr-details-open">open</code> the <code>details</code> element(s) containing
<var>target</var>.

<li><p><span data-x="scroll an element into view">Scroll <var>target</var> into view</span>,
with <var>behavior</var> set to "auto", <var>block</var> set to "start", and <var>inline</var>
set to "nearest". <ref spec=CSSOMVIEW></p></li>
Expand Down Expand Up @@ -114491,8 +114503,9 @@ details[open] > summary {
expected to allow the user to request the details be shown or hidden.</p>

<p>The <code>details</code> element's second <span data-x="concept-slot">slot</span> is expected
to be removed from the rendering when the <code>details</code> element does not have an <code
data-x="attr-details-open">open</code> attribute.</p>
to be hidden when the <code>details</code> element does not have an <code
data-x="attr-details-open">open</code> attribute. The method used to hide the content is a
user-agent choice.</p>
domenic marked this conversation as resolved.
Show resolved Hide resolved

<!-- https://mail.gnome.org/archives/usability/2006-June/msg00015.html -->

Expand Down