Ignore title passed to pushState()/replaceState() #6482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
removal/deprecation
domenic
commented
Mar 12, 2021
| <p>Pushes the given data onto the session history, with the given title, and, if provided and | ||
| not null, the given URL.</p> | ||
| <p>Pushes the given data onto the session history, and, if provided and not null, the given URL. | ||
| (The second parameter exists for historical reasons; passing the empty string is |
There was a problem hiding this comment.
We could link "historical reasons" here and below to https://html5doctor.com/interview-with-ian-hickson-html-editor/ .
|
Seems this got removed in Firefox in https://bugzilla.mozilla.org/show_bug.cgi?id=544535. |
annevk
reviewed
Mar 12, 2021
sagar-barapatre
approved these changes
Mar 13, 2021
annevk
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
Since there are no requirements about manipulating the title element as apparently envisioned at some point, this does not impact what you can observe from the web. It would seem weird if Safari continued to use this parameter though so I hope they agree this should go.
| @@ -82934,18 +82925,20 @@ interface <dfn>History</dfn> { | |||
| <p>If there is no next page, does nothing.</p> | |||
| </dd> | |||
|
|
|||
| <dt><var>window</var> . <code data-x="dom-history">history</code> . <code subdfn data-x="dom-history-pushState">pushState</code>(<var>data</var>, <var>title</var> [, <var>url</var> ] )</dt> | |||
| <dt><var>window</var> . <code data-x="dom-history">history</code> . <code subdfn data-x="dom-history-pushState">pushState</code>( <var>data</var>, ""[, <var>url</var>] )</dt> | |||
There was a problem hiding this comment.
Optional: I don't think we typically have a space after (...
There was a problem hiding this comment.
It varies a lot... we should try to figure out whatwg/meta#190 at some point :-/
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
domenic
added
the
impacts documentation
domenic
added a commit
to WICG/navigation-api
that referenced
this pull request
Mar 15, 2021
It was removed from HTML in whatwg/html#6482.
sideshowbarker
added a commit
to sideshowbarker/browser-compat-data
that referenced
this pull request
Feb 27, 2022
…“title”) Related MDN change: mdn/content#13322 Related spec bug: whatwg/html#6482 Relevant spec sections: - https://html.spec.whatwg.org/multipage/history.html#dom-history-pushstate - https://html.spec.whatwg.org/multipage/history.html#dom-history-replacestate - https://html.spec.whatwg.org/multipage/history.html#dom-history-pushstate-dev - https://html.spec.whatwg.org/multipage/history.html#dom-history-replacestate-dev
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Mar 10, 2022
…“title”) (#15149) * Update History pushstate|replacestate note about “unused” param (was “title”) Related MDN change: mdn/content#13322 Related spec bug: whatwg/html#6482 Relevant spec sections: - https://html.spec.whatwg.org/multipage/history.html#dom-history-pushstate - https://html.spec.whatwg.org/multipage/history.html#dom-history-replacestate - https://html.spec.whatwg.org/multipage/history.html#dom-history-pushstate-dev - https://html.spec.whatwg.org/multipage/history.html#dom-history-replacestate-dev * Rename the actual subfeature too
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2174. Closes #3806.
(See WHATWG Working Mode: Changes for more details.)
/cc @beidson. Note that this doesn't make Safari non-conforming, because browser UI like the back button dropdown is not governed by specs. But Safari might still want to align with the other browsers, if they find the arguments in #2174 (comment) at all persuasive.
/browsing-the-web.html ( diff )
/history.html ( diff )