Move the focus to the previously focused element for dialog.close() #6531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaug----
reviewed
Mar 25, 2021
smaug----
reviewed
Mar 25, 2021
Add a new `previously focused` element to dialog as a pointer to the current focused element when `dialog.showModal()` and `dialog.show()` are called, such that `dialog.close()` can use it to restore the focus. See whatwg#5678 for more details.
sefeng211
force-pushed
the
dialog-move-focus-upon-close
branch
from
8959353 to
9e71dbc
Compare
|
Updated! |
annevk
reviewed
Apr 13, 2021
There was a problem hiding this comment.
This generally looks good to me, modulo nits. Note that we hard wrap lines at a 100 columns (upon a space).
@josepharhar any final thoughts here?
I made a patch here (thanks for the WPT). If the tests pass, then I'm happy with this spec change. |
|
Updated the PR to address the comments. |
annevk
reviewed
Apr 21, 2021
annevk
approved these changes
Apr 27, 2021
annevk
approved these changes
Apr 27, 2021
|
Thanks all! |
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 29, 2021
This change is based on the latest changes for the <dialog> element in whatwg/html#6531, such that closing <dialog> should move the focus to the previously focused element. Differential Revision: https://phabricator.services.mozilla.com/D109726 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1660271 gecko-commit: 130bfa5327532a2b188e4cc06f5e1de7183327e8 gecko-reviewers: smaug
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 30, 2021
…dialog> is closed r=smaug This change is based on the latest changes for the <dialog> element in whatwg/html#6531, such that closing <dialog> should move the focus to the previously focused element. Differential Revision: https://phabricator.services.mozilla.com/D109726
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 30, 2021
This change is based on the latest changes for the <dialog> element in whatwg/html#6531, such that closing <dialog> should move the focus to the previously focused element. Differential Revision: https://phabricator.services.mozilla.com/D109726 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1660271 gecko-commit: 130bfa5327532a2b188e4cc06f5e1de7183327e8 gecko-reviewers: smaug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
previously focusedelement to dialog as a pointerto the current focused element when
dialog.showModal()anddialog.show()are called, such thatdialog.close()canuse it to restore the focus.
See #5678 for more details.
cc @josepharhar @domenic @annevk
/interactive-elements.html ( diff )