-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navigation request pc #6659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antosart
force-pushed
the
add-navigation-request-pc
branch
from
May 6, 2021 08:42
8489007
to
1560796
Compare
This change depends on whatwg/fetch#1231 |
annevk
reviewed
May 6, 2021
antosart
force-pushed
the
add-navigation-request-pc
branch
from
May 11, 2021 09:33
1560796
to
8518a0d
Compare
antosart
force-pushed
the
add-navigation-request-pc
branch
from
May 11, 2021 09:36
8518a0d
to
4572df3
Compare
annevk
approved these changes
May 11, 2021
I would like @domenic to land this because of the source browsing context investigation he has been doing. |
antosart
added a commit
to w3c/webappsec-csp
that referenced
this pull request
May 12, 2021
This change depends on whatwg/fetch#1231 and whatwg/html#6659 which add and populate a request's policy container. This change relies on the request's policy container CSP list (instead of the request's client's environment setting object's CSP list) for the checks. This enforces consistency, since the the request's client's environment setting object's CSP list can change during the lifetime of an asynchronous fetch (for example, when following redirects, or when doing a response check), while the request's policy container CSP list is a snapshot at request's creation time.
ryandel8834
added a commit
to ryandel8834/WebAppSec-CSP
that referenced
this pull request
Aug 13, 2022
This change depends on whatwg/fetch#1231 and whatwg/html#6659 which add and populate a request's policy container. This change relies on the request's policy container CSP list (instead of the request's client's environment setting object's CSP list) for the checks. This enforces consistency, since the the request's client's environment setting object's CSP list can change during the lifetime of an asynchronous fetch (for example, when following redirects, or when doing a response check), while the request's policy container CSP list is a snapshot at request's creation time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stores a snapshot of the initiator policy container on the navigation request. This has no effect by itself, but together with a companion change to CSP it will enable to check policies consistently during the navigation, fixing whatwg/fetch#832 for navigation requests.
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )