-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the list of activation triggering input events #7248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great direction and I'm supportive. I wish you best of luck in gathering multi-implementer agreement and tests. In this case the bar I would apply before merging is general agreement that this is an improvement on the current spec (which already has an XXX box saying "The event set is inconsistent across major browsers. See issue #3849."), plus comprehensive tests to the extent possible so that we can lock in the gains here.
- Removed all high-level events that follows a low-level event. - Added missing low-level events that are known to be required. - Added keyboard events in a conditinal manner.
08a53ad
to
55f3267
Compare
Here is the Chromium CL (under review) that would add matching tests to WPT repository. |
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242442 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#934619}
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242442 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#934619}
@annevk and @eric-carlson: please take a look, I have incorporated all discussion points in the issue. Tests: We have just landed WPTs. The live status is available here, see the tests named |
…ers to match spec proposal., a=testonly Automatic update from web-platform-tests Fine-tune wpts for user-activation triggers to match spec proposal. Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0 -- wpt-commits: 3704e78870c66cf9424a1bebfa441198335c002c wpt-pr: 31373
…ers to match spec proposal., a=testonly Automatic update from web-platform-tests Fine-tune wpts for user-activation triggers to match spec proposal. Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0 -- wpt-commits: 3704e78870c66cf9424a1bebfa441198335c002c wpt-pr: 31373
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me.
Really great to see this fixed! I love the incremental progress in this area, first with "user activation v2" and then later tightening up the events in this way. |
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Proposed HTML PR: whatwg/html#7248 Manually verified that these tests pass in Firefox. Change-Id: I910158680a3741290ba9beef2c29050c11763be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242442 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#934619} NOKEYCHECK=True GitOrigin-RevId: 344664adfe08ed7b2bd1a9efb29ffe15f94767d6
Related to: #3849
mousedown
).activation-trigger-*.html
.(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/interaction.html ( diff )