Add a performance entry type for visibility state changes #8206
Conversation
There was a problem hiding this comment.
I removed set the visibility state and instead queued an entry directly from the place where we set an active document, with timestamp 0. I prefer if when adding this we don't change the implementation in a way that adds more visibilitychange events and changes to other specs.
Thanks! I'm still working on the WPTs :)
You're right, I saw @dbaron's name (it's from the time when he was still at Mozilla) but it's W3CTag. @dbaron do you remember who from Mozilla was involved in this? /cc @emilio |
|
@sefeng211 does the performance team have any concern with this? |
|
Ping @sefeng211 for any opinions from Mozilla? |
|
This looks good from our side. |
|
Thanks! @noamr I'll wait to merge this until you give the sign that you're ready to ship this in Chromium, and file appropriate Gecko/WebKit bugs. Also if you could fix the merge conflicts that would be lovely. |
On it. AFAICT the chromium implementation has been ready for a while, will double check and start the I2S thing etc. thanks! |
source
Outdated
| @@ -94920,6 +94993,11 @@ location.href = '#foo';</code></pre> | |||
| <span>node navigable</span>'s <span data-x="nav-traversable">traversable navigable</span>'s | |||
| <span>system visibility state</span>.</p></li> | |||
|
|
|||
| <li><p><span data-x="queue a performance entry">Queue</span> a new | |||
There was a problem hiding this comment.
I'm not sure I get this.. This is queueing an entry when the document becomes active, but AFAICT that doesn't necessarily map to all the places where the visibility state gets updated. (e.g. I don't think this is called when the document is hidden)
There was a problem hiding this comment.
Oh maybe something important got lost in the rebase. Let me check
There was a problem hiding this comment.
The entry is added when the visiblity changes for any reason, and an initial entry is added when the document becomes active.
See w3c/performance-timeline#105
See also w3c/page-visibility#29
This is the solution that was proposed at WebPerfWG (TODO add link to minutes)
See Design review at CTAG
At least two implementers are interested (and none opposed):
Tests are written and can be reviewed and commented upon at:
VisibilityStateEntryweb-platform-tests/wpt#35620Implementation bugs are filed:
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/interaction.html ( diff )
/references.html ( diff )