Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the navigation API #8502

Merged
merged 36 commits into from
Jun 26, 2023
Merged

Add the navigation API #8502

merged 36 commits into from
Jun 26, 2023
+4,638 −498

Commits on Jan 18, 2023

  1. Add the navigation API 

    This imports much of the specification from https://wicg.github.io/navigation-api/. It includes some minor fixes and renamings, as well as a lot of rearranging to flow better, but the feature set is the same.
    @domenic
    domenic committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    fe5bbc4 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Allow same-URL push navigations and clean up some redundancy

    @domenic
    domenic committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0e2536f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into navigation-api

    @domenic
    domenic committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2ae417a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Adaptation of Chromium state machine fix 

    See https://chromium-review.googlesource.com/c/chromium/src/+/4262131
    @domenic
    domenic committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    bf1d094 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Sync with Chromium changes

    @domenic
    domenic committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    aad584d View commit details
    Browse the repository at this point in the history

  2. Another attempt

    @domenic
    domenic committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    36833af View commit details
    Browse the repository at this point in the history

  3. Add that note back

    @domenic
    domenic committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c59c050 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'main' into navigation-api

    @domenic
    domenic committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    78f2d83 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. History-action user activation, mostly used (still need to consume)

    @domenic
    domenic committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0882857 View commit details
    Browse the repository at this point in the history

  2. Savepoint. Still not firing for traverses quite right.

    @domenic
    domenic committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5fd15c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Move finish call 

    Aligns with latest work in https://chromium-review.googlesource.com/c/chromium/src/+/4262131/10
    @domenic
    domenic committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    86718c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'main' into navigation-api

    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    47beb97 View commit details
    Browse the repository at this point in the history

  2. Some fixes to committed/finished promise

    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    9107af9 View commit details
    Browse the repository at this point in the history

  3. Revamp so we properly fire same-document traversals

    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    e21fdd1 View commit details
    Browse the repository at this point in the history

  4. Final plumbing; also fix check on traverse navigate events

    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    a6f49ea View commit details
    Browse the repository at this point in the history

  5. Rewrap using specfmt

    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ee954bf View commit details
    Browse the repository at this point in the history

  6. Add IPR and ack

    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    e4c0b45 View commit details
    Browse the repository at this point in the history

  7. Remove new CSS 

    A whatwg.org PR is out
    @domenic
    domenic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    79c2104 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Fixes to child navigable destruction 

    Similar to https://chromium-review.googlesource.com/c/chromium/src/+/4313039
    @domenic
    domenic committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    20c3658 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Adapt code cleanup from Chromium 

    https://chromium-review.googlesource.com/c/chromium/src/+/4316506
    @domenic
    domenic committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c031deb View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Easy fixes

    @domenic
    domenic committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    5a7db73 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Cancelable traversals logic fix 

    Follows https://chromium-review.googlesource.com/c/chromium/src/+/4357920
    @domenic
    domenic committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    0252d6d View commit details
    Browse the repository at this point in the history

  2. Slight simplification and invariant fix, again 

    Follows https://chromium-review.googlesource.com/c/chromium/src/+/4355034
    @domenic
    domenic committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2249652 View commit details
    Browse the repository at this point in the history

  3. Address Jake's review

    @domenic
    domenic committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    338d450 View commit details
    Browse the repository at this point in the history

  4. Restrictions on user navigation involvement 

    Also quoted all instances of event.type comparison...
    @domenic
    domenic committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8826b49 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Add fully active check 

    Found while doing a code refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/4369772

#2621 is related, but since we don't have an overall fix yet, let's patch it here
    @domenic
    domenic committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    03bc42d View commit details
    Browse the repository at this point in the history

  2. Fixes per review

    @domenic
    domenic committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    134f567 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'main' into navigation-api

    @domenic
    domenic committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5f7a920 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'main' into navigation-api

    @domenic
    domenic committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    e40d5a9 View commit details
    Browse the repository at this point in the history

  2. Fix nit

    @domenic
    domenic committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f9bef6e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Make destination.index a dynamic getter

    @domenic
    domenic committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f7b6660 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Add an introduction per Anne's request

    @domenic
    domenic committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    92982e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Share more infrastructure between NavigationDestination and Navigatio… 

    …nHistoryEntry

Follows https://chromium-review.googlesource.com/c/chromium/src/+/4406494.
    @domenic
    domenic committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    aaf168b View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Found a typo

    @domenic
    domenic committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    0818829 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Merge branch 'main' into navigation-api

    @domenic
    domenic committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    8273e28 View commit details
    Browse the repository at this point in the history

  2. Don't use AbortSignal/signal abort

    @domenic
    domenic committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    40c167d View commit details
    Browse the repository at this point in the history