Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export navigable container document #8556

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Export navigable container document #8556

merged 1 commit into from
Nov 30, 2022

Conversation

antosart
Copy link
Member

@antosart antosart commented Nov 28, 2022 •
edited by pr-preview bot
Loading

@antosart antosart mentioned this pull request Nov 28, 2022
Merged
@antosart antosart force-pushed the export-navigable-container-document branch from 358bd48 to fa30be2 Compare November 29, 2022 06:45
@antosart antosart changed the title Export navigable container document Export some definitions Nov 29, 2022
@antosart antosart requested a review from domenic November 29, 2022 06:45
@domenic
Copy link
Member

domenic commented Nov 30, 2022

I think it would be best if we only exported navigable container document.

  • Other specs should generally not reference CSP-derived sandboxing flags; I see in Fix references to html after navigation and session history rewrite w3c/webappsec-csp#580 you are adding to a section that generally explains how HTML works, and for other items in that section, you use the <a spec=html>un-exported term</a> syntax to get access. That's what I'd recommend in this case.

  • The "plugin" term should go away completely, once someone makes time for it: Removing plugins? #6003. Exporting the term so that others can create dependencies on it seems like a step backward.

WDYT?

@antosart antosart force-pushed the export-navigable-container-document branch from fa30be2 to ce40498 Compare November 30, 2022 11:26
@antosart antosart changed the title Export some definitions Export navigable container document Nov 30, 2022
@antosart
Copy link
Member Author

Makes sense. Done.

@domenic domenic merged commit 378cb43 into whatwg:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antosart @domenic