Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: change "show popover" to call "check popover validity" first #9439

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Editorial: change "show popover" to call "check popover validity" first #9439

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25edd1c
Change "show popover" to call "check popover validity" first
mbrodesser-Igalia Jun 19, 2023
1126390
Define "cleanupShowingFlag" in "show popover" after defining "nestedS…
mbrodesser-Igalia Jun 19, 2023
0edd08f
Start new line earlier so that `.` isn't at the line's end
mbrodesser-Igalia Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82457,12 +82457,23 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
element</span> or null <var>invoker</var>:</p>

<ol>
<li><p>If the result of running <span>check popover validity</span> given <var>element</var>,
false, <var>throwExceptions</var>, and null is false, then return.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that "popover showing or hiding" is no longer set to false. Is that correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's what implementations (Gecko and Chromium at least) do anyway.

Be ware that "check popover validity" might need to be adapted as part of whatwg/dom#1185 (see whatwg/dom#1185 (comment) and whatwg/dom#1185 (comment)).


<li><p>Let <var>document</var> be <var>element</var>'s <span>node document</span>.</p></li>

<li><p><span>Assert</span>: <var>element</var>'s <span>popover invoker</span> is null.</p></li>

<li><p>Set <var>element</var>'s <span>popover invoker</span> to <var>invoker</var>.</p></li>

<li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
layer</span>.</p></li>

<li><p>Let <var>nestedShow</var> be <var>element</var>'s <span>popover showing or hiding</span>.
</p></li>
annevk marked this conversation as resolved.
Show resolved Hide resolved

<li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>

<li>
<p>Let <var>cleanupShowingFlag</var> be the following steps:</p>

Expand All @@ -82472,20 +82483,6 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
</ol>
</li>

<li><p>If the result of running <span>check popover validity</span> given <var>element</var>,
false, <var>throwExceptions</var>, and null is false, then run <var>cleanupShowingFlag</var> and
return.</p></li>

<li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
layer</span>.</p></li>

<li><p>Let <var>nestedShow</var> be false.</p></li>

<li><p>If <var>element</var>'s <span>popover showing or hiding</span> is true, then set
<var>nestedShow</var> to true.</p></li>

<li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>

<li><p>If the result of <span data-x="concept-event-fire">firing an event</span> named <code
data-x="event-beforetoggle">beforetoggle</code>, using <code>ToggleEvent</code>, with the <code
data-x="dom-Event-cancelable">cancelable</code> attribute initialized to true, the <code
Expand Down