Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with css-view-transitions-1 #9524

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Jul 17, 2023

Upstream monkey patches from css-view-transitions-1:

(See WHATWG Working Mode: Changes for more details.)


/infrastructure.html ( diff )
/references.html ( diff )
/webappapis.html ( diff )

@noamr noamr requested a review from domenic July 17, 2023 11:10
Copy link
Contributor

@khushalsagar khushalsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple; thanks! Just some minor stuff about how we prefer to shield readers of HTML from the versioning stuff that CSS specs do.

spec=CSSVIEWTRANSITIONS1></p>

<ul class="brief">
<li><dfn data-x-href="https://drafts.csswg.org/css-view-transitions-1/#perform-pending-transition-operations">perform pending transition operations</dfn></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere, use the unversioned URLs (no -1).

Also, it's common practice so far to omit the version numbers from our hand-curated bibliographies, so in the <cite> and bibliography, just say CSS View Transitions. And rename the spec slug to CSSVIEWTRANSITIONS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@domenic domenic merged commit d76e077 into whatwg:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants