-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with css-view-transitions-1 #9524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple; thanks! Just some minor stuff about how we prefer to shield readers of HTML from the versioning stuff that CSS specs do.
spec=CSSVIEWTRANSITIONS1></p> | ||
|
||
<ul class="brief"> | ||
<li><dfn data-x-href="https://drafts.csswg.org/css-view-transitions-1/#perform-pending-transition-operations">perform pending transition operations</dfn></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and elsewhere, use the unversioned URLs (no -1
).
Also, it's common practice so far to omit the version numbers from our hand-curated bibliographies, so in the <cite>
and bibliography, just say CSS View Transitions
. And rename the spec slug to CSSVIEWTRANSITIONS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Upstream monkey patches from css-view-transitions-1:
when rendering is suppressed by view-transitions, there should be no rendering opportunities.
In the rendering phase, before intersection oberver callbacks, perform the transition operations.
At least two implementers are interested (and none opposed):
Tests are written and can be reviewed and commented upon at:
Implementation bugs are filed:
[x] MDN issue: https://developer.mozilla.org/en-US/docs/Web/API/View_Transitions_API
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/references.html ( diff )
/webappapis.html ( diff )