Specify the convenience method for List multiple assignment #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass at adding multiple assignment for lists. Comments and critiques are very much welcomed |
annevk
reviewed
Aug 13, 2024
|
Should we also add an example where we have a size check before assignment? |
dlrobertson
force-pushed
the
list-multiple-assign
branch
from
1155aff
to
a11b6ed
Compare
dlrobertson
commented
Aug 13, 2024
annevk
reviewed
Aug 13, 2024
dlrobertson
force-pushed
the
list-multiple-assign
branch
from
a11b6ed
to
dc49294
Compare
annevk
reviewed
Aug 13, 2024
There was a problem hiding this comment.
@domenic thoughts?
I wonder if we should allow this same syntax to be used for splitting up a tuple. At least it was argued in the issue that using parenthesis here might not be clear enough and there's no need for disambiguation anyway.
domenic
approved these changes
Aug 14, 2024
domenic
reviewed
Aug 14, 2024
Add documentation and a example to specify and document List mulitple assignment.
dlrobertson
force-pushed
the
list-multiple-assign
branch
from
dc49294
to
adb1895
Compare
Co-authored-by: Domenic Denicola <d@domenic.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation and a example to specify and document List mulitple assignment.
Fixes: #509
CC: @inexorabletash
Preview | Diff