Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Test Utils Workstream and Standard #164

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Jun 4, 2021

Closes #140.

db.json Outdated Show resolved Hide resolved
db.json Outdated Show resolved Hide resolved
@foolip foolip requested a review from a team June 4, 2021 08:32
@foolip
Copy link
Member Author

foolip commented Jun 4, 2021

@jgraham would you care to review?

@foolip
Copy link
Member Author

foolip commented Jun 4, 2021

On the naming, we could also name it after what you see in tests using this, which will be testUtils. Or possible we can name it after the Web IDL extended attribute we'll end up having to define, which might be [TestOnly] or [TestExposed]. But the risk with that is it becomes unfashionable as Web IDL keeps evolving its own naming and we want to rename it too.

I think https://testutils.spec.whatwg.org/ looks OK, but the capitalization mismatch is unfortunate.

db.json Outdated Show resolved Hide resolved
db.json Outdated Show resolved Hide resolved
db.json Outdated Show resolved Hide resolved
db.json Outdated
],
"reference": "BROWSER-TESTING-API",
"review_draft_schedule": [
3,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had 15 existing standards, with 5 in each of the (6, 12), (1, 7) and (2, 8) buckets. This starts a new (3, 9) bucket.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a calendar entry to not forgot about it when we merge this.

@annevk annevk changed the title Add the Browser Testing API workstream and standard Add the Test Utils Workstream and Standard Jul 19, 2021
@annevk
Copy link
Member

annevk commented Jul 19, 2021

I updated this to account for the discussion. @othermaciej and @travisleithead could you please review as well?

@foolip
Copy link
Member Author

foolip commented Jul 20, 2021

Thanks @annevk, the changes look good to me!

Copy link
Member

@travisleithead travisleithead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@travisleithead
Copy link
Member

travisleithead commented Aug 18, 2021

Questions from: https://whatwg.org/workstream-policy#workstream-proposals

1 Proposed Workstream name:

  • Provided

2 Statement of purpose, including problem to be solved, proposed solution, status of the proposed solution, and how it is consistent with the WHATWG Principles and appropriate for a Workstream.

  • This is outlined in the issue; status is a proposal for one thing that is relatively mature.

3 Specific Scope of work (included and excluded).

  • Scope statement is present.

4 Proposed deliverables.

  • The standard section defines this (one standard)

5 Draft of the proposed Living Standard plus (optionally) a list of other proposed deliverables.

6 A list of similar or related work being undertaken or proposed elsewhere and its relationship to the proposed Workstream.

  • Related work was WPT, where cross-browsers tests should be provided.

7 Anticipated commencement date and timeline for work going forward.

  • Not provided
    [Note remove this requirement, doesn't really make sense.]

8 Anticipated Workstream Participants.

  • The editor will be the participant
    [Might also consider dropping this requirement.]

9 Description or list of those likely to implement or otherwise have an interest in the work.

  • WebKit is interested, should be sufficient

10 Expectations regarding long-term maintenance of the Living Standard.

  • Editor volunteering should be effectively fulfilled.

Copy link
Contributor

@othermaciej othermaciej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this in light of the requirements for a Workstream Proposal: https://whatwg.org/workstream-policy#workstream-proposals

Items 1-6 and 9-10 seem effectively fulfilled by either this PR or the issue it resolves. After walking through th Workstream Proposal requirements with the SG, we agreed that 7 and 8 do not seem reasonable to ask for up front in a proposal. I agree the waive those two requirements for this PR, and we will likely file an issue to remove them.

I also approve on the substance of the PR, and I believe WebKit would be interested in implementing this spec.

@foolip
Copy link
Member Author

foolip commented Sep 15, 2021

Given that #168 has been merged I'm going to go ahead and merge this. Workstream, exist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Proposed for browser testing spec
5 participants