-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Test Utils Workstream and Standard #164
Conversation
@jgraham would you care to review? |
On the naming, we could also name it after what you see in tests using this, which will be I think https://testutils.spec.whatwg.org/ looks OK, but the capitalization mismatch is unfortunate. |
db.json
Outdated
], | ||
"reference": "BROWSER-TESTING-API", | ||
"review_draft_schedule": [ | ||
3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had 15 existing standards, with 5 in each of the (6, 12), (1, 7) and (2, 8) buckets. This starts a new (3, 9) bucket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a calendar entry to not forgot about it when we merge this.
9b9ff8c
to
d3d562c
Compare
I updated this to account for the discussion. @othermaciej and @travisleithead could you please review as well? |
Thanks @annevk, the changes look good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Questions from: https://whatwg.org/workstream-policy#workstream-proposals 1 Proposed Workstream name:
2 Statement of purpose, including problem to be solved, proposed solution, status of the proposed solution, and how it is consistent with the WHATWG Principles and appropriate for a Workstream.
3 Specific Scope of work (included and excluded).
4 Proposed deliverables.
5 Draft of the proposed Living Standard plus (optionally) a list of other proposed deliverables.
6 A list of similar or related work being undertaken or proposed elsewhere and its relationship to the proposed Workstream.
7 Anticipated commencement date and timeline for work going forward.
8 Anticipated Workstream Participants.
9 Description or list of those likely to implement or otherwise have an interest in the work.
10 Expectations regarding long-term maintenance of the Living Standard.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing this in light of the requirements for a Workstream Proposal: https://whatwg.org/workstream-policy#workstream-proposals
Items 1-6 and 9-10 seem effectively fulfilled by either this PR or the issue it resolves. After walking through th Workstream Proposal requirements with the SG, we agreed that 7 and 8 do not seem reasonable to ask for up front in a proposal. I agree the waive those two requirements for this PR, and we will likely file an issue to remove them.
I also approve on the substance of the PR, and I believe WebKit would be interested in implementing this spec.
Given that #168 has been merged I'm going to go ahead and merge this. Workstream, exist! |
Closes #140.