Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming boxes to bins or something #51

Closed
fantasai opened this issue Oct 19, 2017 · 8 comments
Closed

Consider renaming boxes to bins or something #51

fantasai opened this issue Oct 19, 2017 · 8 comments

Comments

@fantasai
Copy link

This is a very trivial issue, and maybe there's a very good reason not to do this, but given that “box” in CSS has a very specific definition that's used in pretty much every CSS spec and is embedded as a term in some of its APIs, one might consider renaming the Storage concept of “box” to something else?

@fantasai
Copy link
Author

fantasai commented Oct 19, 2017

Or at least maybe just not exporting the definition if it's a spec-internal term...

@annevk
Copy link
Member

annevk commented Oct 20, 2017

@inexorabletash @shuangMoz @jakearchibald thoughts? I'm happy to rename this. We'll need to export something since eventually other specifications will use it.

Bin doesn't seem appropriate since it's not trash. I could prefix it with storage perhaps. So "storage box".

Other alternative: store. But that is also used a lot I suspect.

@domenic
Copy link
Member

domenic commented Oct 20, 2017

FWIW the "trash" association with "bin" is probably more of a regional thing; it isn't in the dictionary. (But I can believe that some places in the world use "trash bin" like Americans use "garbage can".)

@inexorabletash
Copy link
Member

I'm fine with a rename, but no strong preferences.

"store" will get confused with Indexed DB's object store

Internally, Chrome has "partition" for a different concept so I'd vote against that one too.

I'd casually use "bucket" to describe this, but there may be connotations (buckets get full, buckets leak, etc)

@annevk
Copy link
Member

annevk commented Oct 21, 2017

I'm okay with "bucket".

@fantasai
Copy link
Author

fantasai commented Oct 23, 2017

We have trash bin and recycling bin here in the US, and they're understandably the most common, but we also have other kinds of bins. :) The plastic things in here are all called bins. https://www.northerntool.com/images/product/2000x2000/502/50273_2000x2000.jpg (The only other term I can think of atm would be “compartment” but it's less precise for this particular usage.)

annevk added a commit that referenced this issue Oct 25, 2017
This avoids needlessly conflicting with the CSS box model.

Fixes #51.
@annevk
Copy link
Member

annevk commented Oct 25, 2017

I created #52 to address this.

@annevk
Copy link
Member

annevk commented Oct 25, 2017

Per feedback in the PR it seems like it'll be "bucket" after all.

annevk added a commit that referenced this issue Nov 11, 2017
This avoids needlessly conflicting with the CSS box model.

Fixes #51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants