Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note for ReadableStreamDefaultReader.close is confusing #912

Closed
surma opened this issue Mar 28, 2018 · 0 comments
Closed

Note for ReadableStreamDefaultReader.close is confusing #912

surma opened this issue Mar 28, 2018 · 0 comments

Comments

@surma
Copy link
Contributor

surma commented Mar 28, 2018

The note for ReadableStreamDefaultReader.close currently reads:

The closed getter returns a promise that will be fulfilled when the stream becomes closed or the reader’s lock is released, or rejected if the stream ever errors.

@jakearchibald and I think that is not correct.

@jakearchibald’s suggestion for the note:

The closed getter returns a promise that will be fulfilled when the stream becomes closed. It rejects if the reader’s lock is released or the stream errors.

surma added a commit to surma-dump/streams that referenced this issue Mar 28, 2018
surma added a commit to surma-dump/streams that referenced this issue Mar 28, 2018
@ricea ricea closed this as completed in 37ace3d Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant