Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: default branch rename #1101

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Meta: default branch rename #1101

merged 1 commit into from
Jan 15, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 13, 2021

Helps with whatwg/meta#174.

I did not audit the reference-implementation directory. If that is important can an editor take that on?

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Jan 13, 2021
@MattiasBuelens
Copy link
Collaborator

I couldn't find any references to master within the reference implementation directory, so I think we're fine there.

Do we also intend to change the default branch name on this repository? And should that be part of this pull request? If so, we'll need to update:

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2021
@annevk
Copy link
Member Author

annevk commented Jan 14, 2021

Thanks @MattiasBuelens! deploy.sh is not in this repository, I could not find other links in demos/ but I did update the one you found as well as the workflows, and created web-platform-tests/wpt#27182 for WPT (I could not find other such references back to WHATWG repositories).

@annevk annevk requested a review from domenic January 14, 2021 12:29
Copy link
Collaborator

@MattiasBuelens MattiasBuelens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, right, I didn't see that deploy.sh from my working copy was being gitignored. 😅

LGTM. 👍

Copy link
Collaborator

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from master to main January 15, 2021 07:25
@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Jan 15, 2021
@annevk annevk merged commit ca74e0e into main Jan 15, 2021
@annevk annevk deleted the annevk/main branch January 15, 2021 07:28
sideshowbarker pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 15, 2021
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 19, 2021
Automatic update from web-platform-tests
Streams: update link in README

Complements whatwg/streams#1101.

--

wpt-commits: 76922fbbf9dafe8bd53e9d47f5be3d12b83c9a3d
wpt-pr: 27182
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 25, 2021
Automatic update from web-platform-tests
Streams: update link in README

Complements whatwg/streams#1101.

--

wpt-commits: 76922fbbf9dafe8bd53e9d47f5be3d12b83c9a3d
wpt-pr: 27182

UltraBlame original commit: a436a5e99c3110277ed67d79f65068ceffc3bd11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants