Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty host file URL fallout? #272

Closed
annevk opened this issue Mar 14, 2017 · 0 comments
Closed

Empty host file URL fallout? #272

annevk opened this issue Mar 14, 2017 · 0 comments
Labels
topic: parser

Comments

@annevk
Copy link
Member

annevk commented Mar 14, 2017

From @domenic in #260 (comment):

Note that there is no test coverage for the case introduced here: in

       if (this.url.host !== "" && this.url.host !== null) {
         this.parseError = true;
         this.url.host = "";
       }

the condition never evaluates to true so those two lines are never reached. Maybe a coverage gap, maybe a spec bug.
@rmisev rmisev mentioned this issue Mar 14, 2017
Merged
domenic pushed a commit to web-platform-tests/wpt that referenced this issue Mar 14, 2017
@rmisev @domenic
File URL's parsing tests for path state
634175d 
Tests windows drive letter quirk in the path state: https://url.spec.whatwg.org/#path-state

Fixes whatwg/url#272 (whatwg/url#260 (comment))
@valenting valenting mentioned this issue Nov 2, 2017
Merged
bors-servo pushed a commit to servo/rust-url that referenced this issue Nov 6, 2017
Auto merge of #410 - valenting:win-file-letter, r=SimonSapin
c6284a2 
Properly file URLs when the path starts with a windows drive letter

This change imports tests from web-platform-tests/wpt@634175d corresponding to URL change whatwg/url#272

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/410)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: parser
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk