Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopher test updates do not match spec updates #455

Closed
domenic opened this issue Oct 18, 2019 · 1 comment
Closed

gopher test updates do not match spec updates #455

domenic opened this issue Oct 18, 2019 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Oct 18, 2019

#453 and web-platform-tests/wpt#19770 do not match.

First, the tests expect gopher to also be removed from the list of origins which get serialized nicely: https://url.spec.whatwg.org/#concept-url-origin

even after that, the following tests fail:

 Web platform tests › setters › protocol › <gopher://example.net:1234>.protocol = "file" 

    Expected value to be equal to:
      "gopher://example.net:1234/"
    Received:
      "gopher://example.net:1234"

Web platform tests › setters › protocol › <ssh://me@example.net>.protocol = "gopher" 

    Expected value to be equal to:
      "ssh://me@example.net"
    Received:
      "gopher://me@example.net"

I think these latter two are test issues. The former could either be a test or spec issue, depending on whether people think #454 is correct.

domenic added a commit to web-platform-tests/wpt that referenced this issue Oct 18, 2019
annevk pushed a commit that referenced this issue Oct 21, 2019
After #453 the gopher scheme is not special anymore. According to web-platform-tests/wpt#19770 the intention is that a gopher URL's origin would be opaque (null). Fixes part of #455.
annevk pushed a commit to web-platform-tests/wpt that referenced this issue Oct 21, 2019
@annevk
Copy link
Member

annevk commented Oct 21, 2019

Thanks!

@annevk annevk closed this as completed Oct 21, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 24, 2019
…r being special, a=testonly

Automatic update from web-platform-tests
Fix URL setter tests for gopher no longer being special

Part of whatwg/url#455.
--

wpt-commits: 43feb7f612fe9160639e09a47933a29834904d69
wpt-pr: 19790
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Oct 24, 2019
…r being special, a=testonly

Automatic update from web-platform-tests
Fix URL setter tests for gopher no longer being special

Part of whatwg/url#455.
--

wpt-commits: 43feb7f612fe9160639e09a47933a29834904d69
wpt-pr: 19790
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 27, 2019
…r being special, a=testonly

Automatic update from web-platform-tests
Fix URL setter tests for gopher no longer being special

Part of whatwg/url#455.
--

wpt-commits: 43feb7f612fe9160639e09a47933a29834904d69
wpt-pr: 19790

UltraBlame original commit: d1e334e9429443f3f346706081587ed509fab4da
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 27, 2019
…r being special, a=testonly

Automatic update from web-platform-tests
Fix URL setter tests for gopher no longer being special

Part of whatwg/url#455.
--

wpt-commits: 43feb7f612fe9160639e09a47933a29834904d69
wpt-pr: 19790

UltraBlame original commit: d1e334e9429443f3f346706081587ed509fab4da
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 27, 2019
…r being special, a=testonly

Automatic update from web-platform-tests
Fix URL setter tests for gopher no longer being special

Part of whatwg/url#455.
--

wpt-commits: 43feb7f612fe9160639e09a47933a29834904d69
wpt-pr: 19790

UltraBlame original commit: d1e334e9429443f3f346706081587ed509fab4da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants