Forbid <, >, and ^ in hosts #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
annevk
reviewed
May 7, 2020
annevk
added
the
needs tests
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
|
Sadly I'm not able to spare the creative energy for writing tests, but I can do the usual jsdom/whatwg-url testing and reviewing. In advance I will report that there is only one failure in the existing test suite, which is parsing |
4 tasks
rmisev
added a commit
to rmisev/web-platform-tests
that referenced
this pull request
May 13, 2020
See whatwg/url#459 for context
|
Added tests: web-platform-tests/wpt#23572 |
domenic
approved these changes
May 14, 2020
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
May 14, 2020
This was referenced May 14, 2020
|
Thanks everyone! I filed https://bugs.webkit.org/show_bug.cgi?id=211901. Firefox and Chrome already have a more general bug on implementing non-special URLs properly. |
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 14, 2020
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
May 14, 2020
yashLadha
added a commit
to yashLadha/node
that referenced
this pull request
May 21, 2020
As per the recent changes in whatwg/url spec. lt and gt are also added in the list of forbidden hostCodePoint list. Ref: whatwg/url#459 Ref: nodejs#33315
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
As per the recent changes in whatwg/url spec. lt and gt are also added in the list of forbidden hostCodePoint list. PR-URL: nodejs#33328 Refs: whatwg/url#459 Refs: nodejs#33315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 26, 2020
…only Automatic update from web-platform-tests URL: forbid <, >, and ^ in hosts Follows whatwg/url#459. -- wpt-commits: 9ffe8f26432649d02eb81add2816dd5394f57a8c wpt-pr: 23572
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 26, 2020
…only Automatic update from web-platform-tests URL: forbid <, >, and ^ in hosts Follows whatwg/url#459. -- wpt-commits: 9ffe8f26432649d02eb81add2816dd5394f57a8c wpt-pr: 23572
djc
added a commit
to servo/rust-url
that referenced
this pull request
Aug 18, 2020
Per the change in whatwg/url#459.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
<and>toHost miscellaneous, Close #458Preview | Diff