Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for a trailing dot in public suffix and registrable domain #694

Merged
merged 1 commit into from
May 3, 2022

Conversation

annevk
Copy link
Member

@annevk annevk commented May 2, 2022

Also update the PSL algorithm reference.

Fixes #692 and fixes #693.

(This depends on whatwg/infra#446.)


Preview | Diff

Also update the PSL algorithm reference.

Fixes #692 and fixes #693.
@annevk annevk requested a review from domenic May 2, 2022 12:23
@dnsguru
Copy link

dnsguru commented May 2, 2022

Just want to confirm, this needs no action from within PSL side, correct?

(PSL Volunteer here)

@annevk
Copy link
Member Author

annevk commented May 3, 2022

Yeah, that's correct. It would be good to get a heads up if the formal algorithm moves again or is modified in some fashion. Thanks!

@annevk annevk merged commit 4ef812c into main May 3, 2022
@annevk annevk deleted the annevk/psl-trailing-dots branch May 3, 2022 08:09
@dnsguru
Copy link

dnsguru commented Oct 11, 2022 via email

@annevk
Copy link
Member Author

annevk commented Oct 11, 2022

@dnsguru if you have some kind of process document for changes of this nature I'd be happy to add a line along the lines of "file an issue against the URL standard" which should encompass most browser usage.

@dnsguru
Copy link

dnsguru commented Oct 11, 2022 via email

@annevk
Copy link
Member Author

annevk commented Oct 11, 2022

@dnsguru e.g., https://github.com/tc39/ecma262/blob/main/CONTRIBUTING.md outlines how to contribute to ECMAScript. In there, it says that if you change certain constructs that will have an impact downstream and encourages you to file issues upon certain known places (Web IDL, HTML, ...). It seems PSL could do something similar.

@dnsguru
Copy link

dnsguru commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Can a registrable domain or public suffix have a trailing dot? PSL references broken
3 participants