Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant domain to Unicode call from valid domain #840

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 29, 2024

I'm not entirely sure why this redundant check existed. Either because there was a difference back when this definition was introduced in 3bec3b8 or (more likely) I wasn't sure if there was a difference.

Fixes #817.


Preview | Diff

I'm not entirely sure why this redundant check existed. Either because there was a difference back when this definition was introduced in 3bec3b8 or (more likely) I wasn't sure if there was a difference.

Fixes #817.
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@annevk annevk merged commit da212c9 into main Nov 29, 2024
2 checks passed
@annevk annevk deleted the annevk/valid-domain branch November 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Explain why valid domain needs to run ToUnicode
2 participants