Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IDNA's CheckHyphens to the value of beStrict #842

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 29, 2024

It makes more sense if it's consistent with UseSTD3ASCIIRules and VerifyDnsLength.

Fixes #820.


Preview | Diff

It makes more sense if it's consistent with UseSTD3ASCIIRules and VerifyDnsLength.

Fixes #820.
@annevk annevk added topic: idna topic: validation Pertaining to the rules for URL writing and validity (as opposed to parsing) labels Nov 29, 2024
@annevk annevk requested review from hsivonen and rmisev November 29, 2024 09:13
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@annevk annevk merged commit cd8f1d6 into main Nov 29, 2024
2 checks passed
@annevk annevk deleted the annevk/checkhyphens branch November 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: idna topic: validation Pertaining to the rules for URL writing and validity (as opposed to parsing)
Development

Successfully merging this pull request may close these issues.

CheckHyphens isn't set to beStrict
2 participants