Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IDNA's IgnoreInvalidPunycode to false #843

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 29, 2024

Also move UseSTD3ASCIIRules around in Unicode ToASCII to align with the UTS46 order.

While this is not a change in behavior, this is not marked as editorial as UTS46 integration is somewhat significant and worth highlighting.

Fixes #821.


Preview | Diff

Also move UseSTD3ASCIIRules around in Unicode ToASCII to align with the UTS46 order.

While this is not a change in behavior, this is not marked as editorial as UTS46 integration is somewhat significant and worth highlighting.

Fixes #821.
@annevk annevk requested review from hsivonen and rmisev November 29, 2024 10:03
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@annevk annevk merged commit a6e4492 into main Nov 29, 2024
2 checks passed
@annevk annevk deleted the annevk/IgnoreInvalidPunycode branch November 29, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Initialize the IgnoreInvalidPunycode flag when calling UTS 46
2 participants