Restrict the extended attributes for partial interfaces. #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like a bad idea to allow [Global] on a partial interface. The behavior of [Exposed] and [SecureContext] on partial interfaces is already defined in the relevant algorithms. The behavior of [OverrideBuiltins] is defined here with the same vague wording used before. It might be better to disentangle the concept of an interface and its syntactical structure. Fixes #154.
|
Are there any existing usages of [OverrideBuiltins] on a partial interface? My suspicion is not, in which case, it'd be better to ban it. |
|
|
Fair :/. I wonder if moving the annotation to DOM would be an improvement or just weird to have things spread out. Probably not worth addressing at this time. |
domenic
approved these changes
Jan 28, 2019
|
Given it's on the legacy list per #350 it doesn't seem worth bothering about it too much unless it starts blocking something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a bad idea to allow [Global] on a partial interface.
The behavior of [Exposed] and [SecureContext] on partial interfaces is already
defined in the relevant algorithms.
The behavior of [OverrideBuiltins] is defined here with the same vague wording
used before. It might be better to disentangle the concept of an interface and
its syntactical structure.
Fixes #154.
Preview | Diff