Editorial: slightly modernize API definitions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduces internal slots for "binary type" and "ready state" * Uses "method steps"/"getter steps"/"setter steps" uniformly * Updates domintro to more closely follow the conventions discussed in whatwg/meta#190 (comment)
domenic
added
the
do not merge yet
|
Right, IPR checker bot won't work until whatwg/sg#180 is merged and participate.whatwg.org is re-deployed. Still feel free to review, but we shouldn't merge until that comes through and we have a proper end-to-end test. |
ricea
reviewed
Dec 1, 2021
index.bs
Outdated
| 1. If the {{WebSocket/readyState}} attribute's value is not {{WebSocket/OPEN}}</code> (1), then | ||
| return. | ||
| 1. Let |dataForEvent| be determined by switching on |type| and {{WebSocket/binaryType}}: | ||
| 1. If [=WebSocket/ready state=] ]is not {{WebSocket/OPEN}}</code> (1), then return. |
There was a problem hiding this comment.
This </code> appears to be unmatched.
domenic
removed
the
do not merge yet
|
Woohoo, IPR checker bot works. Merge at will. |
|
Ping @ricea for green checkmark so we can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... mostly sending this to test the IPR checker bot, although I admit I got a bit carried away.