Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redix does not provide any error message and just exit here #254

Closed
etemadmo opened this issue Sep 14, 2023 · 1 comment
Closed

Redix does not provide any error message and just exit here #254

etemadmo opened this issue Sep 14, 2023 · 1 comment

Comments

@etemadmo
Copy link

https://github.com/whatyouhide/redix/blob/59224955c788745a2b82b916d19919ec594b53bd/lib/redix/connection.ex#L85C4-L85C21
It would be a better user experience if before exit we had an error or we could return error instead of just exit

@whatyouhide
Copy link
Owner

That EXIT is propagating the exit reason of the Redix process and exits the caller process with that reason.

However, yes, we can make it a little bit better. Something like:

exit({:redix_exited_during_call, reason})

Thoughts? I'd appreciate a PR on this, I don't really have any bandwidth right now 🙃

etemadmo pushed a commit to etemadmo/redix that referenced this issue Sep 15, 2023
whatyouhide added a commit that referenced this issue Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants