New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 758 External Wheel Hosting #1

Merged

warsawnv merged 8 commits into wheel-next:main from warsawnv:warsawnv/pep-758

Oct 1, 2024

warsawnv commented Sep 20, 2024

No description provided.


          PEP 758 first draft

943a4c6

warsawnv self-assigned this

warsawnv requested review from aterrel and emmatyping-nv

September 20, 2024 02:02


          Fix linting

39fd186

Discussions-To will have to be added after posted to DPO

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Outdated Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Outdated Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Outdated Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Outdated Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Outdated Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Show resolved Hide resolved

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Show resolved Hide resolved

warsaw commented Sep 23, 2024

Two suggestions I've heard from chatting with people at the core Python sprint, that I want to capture:

EXTERNAL-HOSTED should be JSON
We should include wheel size in the metadata, so that an installer can avoid downloading a size-spoofed external wheel before unpacking it and verifying the checksum.

warsaw and others added 4 commits

September 26, 2024 10:02


          Improved wording

d80624c

Co-authored-by: Ethan Smith <etsmith@nvidia.com>


          Elaboration

35b60db

Co-authored-by: Ethan Smith <etsmith@nvidia.com>


          External hosting is org-wide

17e8a8c

Co-authored-by: Ethan Smith <etsmith@nvidia.com>


          Installer must read the Owner field from the rim file

84e4717

Co-authored-by: Ethan Smith <etsmith@nvidia.com>

warsaw commented Sep 26, 2024

We should include wheel size in the metadata, so that an installer can avoid downloading a size-spoofed external wheel before unpacking it and verifying the checksum.

Given that I'm changing the file to EXTERNAL-HOSTED.json, maybe we should add a hashes dictionary a la PEP 694 rather than requiring the URL to have a fragment with the hash value. This would allow clients to provide multiple hashes with different algorithms. I'm thinking about this because I also want to set the file size in the JSON.


          Respond to wheel-next feedback:

66fa967

* Add size and hashes dictionaries
* HTTP range requests is a MUST
* HTTP/2 is a SHOULD

warsaw commented Sep 27, 2024

@ethanhs-nv I think I've resolved all the suggestions. Thanks for the valuable feedback! Unless there's anything else you think needs further elaboration, my plan is to submit this against the real peps repo and open a DPO thread on Monday.

emmatyping-nv reviewed

View reviewed changes

peps/pep-0758.rst Outdated Show resolved Hide resolved

emmatyping-nv commented Sep 27, 2024

@warsaw I think it looks great! Looking forward to seeing it live!


          Don't state the obvious!

08de671

emmatyping-nv approved these changes

View reviewed changes

emmatyping-nv left a comment

Very excited to see this published in the PEPs repo, thank you for going through all my feedback :P

warsawnv merged commit 2df94bc into wheel-next:main

warsawnv deleted the warsawnv/pep-758 branch

October 1, 2024 18:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet