Stop video track when disabling video #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havardholvik
force-pushed
the
havard/pan-259-make-sure-we-turn-off-camera-light-when-disabling-video
branch
from
75e5d70 to
c4825b5
Compare
nandito
reviewed
Oct 24, 2023
havardholvik
force-pushed
the
havard/pan-259-make-sure-we-turn-off-camera-light-when-disabling-video
branch
3 times, most recently
from
00b052f to
3cb5b35
Compare
In order to make the camera light turn off, we need to stop the video track completely.
havardholvik
force-pushed
the
havard/pan-259-make-sure-we-turn-off-camera-light-when-disabling-video
branch
2 times, most recently
from
f30fb4b to
811ded3
Compare
We have previously failed to install the latest dependencies of the sdk when installing the sample app. This change here makes sure `yarn installed` is run AFTER adding the local yalc dependency.
havardholvik
force-pushed
the
havard/pan-259-make-sure-we-turn-off-camera-light-when-disabling-video
branch
from
811ded3 to
9e6870a
Compare
havardholvik
deleted the
havard/pan-259-make-sure-we-turn-off-camera-light-when-disabling-video
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the camera light turn off, we need to stop the video track completely.
Tested like:
yarn dev-> connect to room through Storybook