Type custom event payloads #103
Conversation
kevinwhereby
changed the base branch from
development
to
nandor/pan-400-rename-rejected-knock_rejected
kevinwhereby
force-pushed
the
kevinhanna/room-event-typing
branch
from
d49bdf9 to
48029d5
Compare
| stream, | ||
| id: streamId, | ||
| isLocal: false, | ||
| hasAudioTrack: stream.getAudioTracks().length > 0, |
There was a problem hiding this comment.
unsure if this is correct... input welcome
There was a problem hiding this comment.
I think this should be sufficient. It at least answers the question the prop seemingly asks hasAudioTrack. However, the track could be disabled, meaning no audio, but I honestly dont know if that is the case event for a screenshare started without audio. I would keep 👍
There was a problem hiding this comment.
I guess semantically hasAudioTrack would still be true in this case even if it was disabled or muted right?
But yeah, we can find out if it becomes an issue I guess
There was a problem hiding this comment.
Yep, we are staying true to the prop name 👍
| stream, | ||
| id: streamId, | ||
| isLocal: false, | ||
| hasAudioTrack: stream.getAudioTracks().length > 0, |
There was a problem hiding this comment.
I think this should be sufficient. It at least answers the question the prop seemingly asks hasAudioTrack. However, the track could be disabled, meaning no audio, but I honestly dont know if that is the case event for a screenshare started without audio. I would keep 👍
thin wrappers around CustomEvent that will enforce our payload types on the created events
kevinwhereby
force-pushed
the
kevinhanna/room-event-typing
branch
from
c3dd0d3 to
e3503e1
Compare
Adds a thing custom event wrapper that ensures our events align with what we define in RoomEventsMap and LocalMediaEventsMap
To test
Gotchas
relies on us using
RoomEvent|LocalMediaEvent, so if someone comes along and adds another handler usingCustomEventwe lose the typings...We could add a
this._dispatchRoomEvent(e: RoomEvent)function to the class to solve this maybe?But then someone could just use
this.dispatchEvent(e)to get around that...Maybe it's not a big deal