separate module imports #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwhereby
force-pushed
the
kevinhanna/separate-module-exports
branch
from
746fa81 to
da9c39b
Compare
havardholvik
approved these changes
Oct 27, 2023
kevinwhereby
changed the base branch from
development
to
nandor/pan-400-rename-rejected-knock_rejected
We dont want to expose the LocalMeda and RoomConnection classes just yet, so leave them out of the exports.
kevinwhereby
force-pushed
the
kevinhanna/separate-module-exports
branch
from
a60c37f to
b069f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the default export from /dist and exports separate subpaths from /dist/react and /embed
test
import { useRoomConnection } from "@whereby.com/browser-sdk/react"orimport("@whereby.com/browser-sdk/embed")It's all working for me on vite/cra/next apps in dev and prod builds which is exciting