bind this to message event listener #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwhereby
force-pushed
the
kevinhanna/pan-359-iframe-events-dont-work-in-the-alpha-build
branch
2 times, most recently
from
da02a77 to
2e705b1
Compare
`this` in onmessage was bound to the parent window, so events were never being forwarded from the iframe, as the `this.url.origin` was always undefined. Removes the need for the null coalesce in `this.url?.origin` as there will be no events triggered before this property is set in `render`
kevinwhereby
force-pushed
the
kevinhanna/pan-359-iframe-events-dont-work-in-the-alpha-build
branch
from
2e705b1 to
b28fadd
Compare
havardholvik
approved these changes
Oct 31, 2023
kevinwhereby
deleted the
kevinhanna/pan-359-iframe-events-dont-work-in-the-alpha-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisin onmessage was bound to the parent context, so events were neverbeing forwarded from the iframe, as the
this.url.originwas alwaysundefined.
Removes the need for the null coalesce in
this.url?.originas therewill be no events triggered before this property is set in
renderto test
document.querySelector("whereby-embed").addEventListener("camera-toggle", () => console.log("Triggered"))gotchas
I tried adding a test for this (since we didn't detect this regression when it happened), but the PWA requirement to accept cam/mic permissions means it won't work in CI