Update dependencies #112
Merged
Update dependencies #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version removes the legacy socket.io-client, which had a few security issues.
...by running `npx yarn-audit-fix`
nandito
force-pushed
the
nandor/pan-428-fix-high-severity-and-critical-vulnerabilities
branch
from
44a4be3 to
36fbef0
Compare
nandito
deleted the
nandor/pan-428-fix-high-severity-and-critical-vulnerabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
security issues.
npx yarn-audit-fixInstalling browser-sdk
Run
yalc add @whereby.com/browser-sdk && npm iin a new project.Yarn audit
Run
yarn auditin this browser-sdk repo.*Most of the remaining vulnerabilities are storybook related. I've spent some time to try to upgrade and migrate to the latest version. Most of the vulnerabilities disappeared, but everything broke (stories, tests, builds), because SB7 uses different babel/webpack configs. 😑 So I just reverted this upgrade for now.
Test plan
Related task
whereby/jslib-media#29