Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up log output #119

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

nandito
Copy link
Collaborator

@nandito nandito commented Nov 7, 2023

Add noop logger by default to hide media debug log messages from the console.

Test plan

  1. Start your sample app without specifying a logger in the room connection config
  2. Check your console log => there should be no media related console messages there anymore
  3. Add a logger to your room connection config, like
    const roomConnection = useRoomConnection(roomUrl, {
        localMediaConstraints: {
            video: true,
            audio: true,
        },
        logger: console,
    });
  4. Start your app => messages like "Connected to signal socket" should be visible in devtool's console.

Add noop logger by default to hide media debug log messages from the
console.
@nandito nandito requested a review from a team November 7, 2023 09:46
@nandito nandito self-assigned this Nov 7, 2023
@havardholvik havardholvik merged commit d53d4a9 into development Nov 7, 2023
2 checks passed
@havardholvik havardholvik deleted the nandor/pan-414-clean-up-log-output branch November 7, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants