Replace esbuild with Rollup #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are seeing some problems with our current build setup, try reverting to rollup.
nandito
approved these changes
Nov 8, 2023
.github/actions/build/action.yml
Outdated
| @@ -5,7 +5,7 @@ runs: | |||
| steps: | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: "16" | |||
| node-version: "18" | |||
There was a problem hiding this comment.
Could 20 work? That's our new target version in the other services.
thyal
approved these changes
Nov 8, 2023
kevinwhereby
reviewed
Nov 8, 2023
Align node version with what we are using elsewhere in the company. Also replace process.env variables with their actual values to prevent setups such as Vite needing more configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are seeing some problems with our current build setup, try reverting to rollup.