Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle rtcstats #123

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Bundle rtcstats #123

merged 2 commits into from
Nov 8, 2023

Conversation

thyal
Copy link
Member

@thyal thyal commented Nov 8, 2023

Add rtcstats to bundle

Copy link
Contributor

@kevinwhereby kevinwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working in the usual suspects

I still see rtcstats in my yarn.lock though... guess we have to publish to really find out of course, because yarn lock doesn't care about bundles 🤦

"@whereby/jslib-media@whereby/jslib-media.git#1.4.1":
  version "1.4.1"
  resolved "https://codeload.github.com/whereby/jslib-media/tar.gz/abc55b7e2d3af9c71cb3f3a2953291bb79725064"
  dependencies:
    events "^3.3.0"
    mediasoup-client "3.6.100"
    rtcstats "github:whereby/rtcstats#v5.3.0"
    sdp "^2.2.0"
    sdp-transform "^2.14.1"
    socket.io-client "4.7.2"
    uuid "^9.0.1"
    webrtc-adapter "^7.3.0"

"rtcstats@github:whereby/rtcstats#v5.3.0":
  version "5.3.0"
  resolved "https://codeload.github.com/whereby/rtcstats/tar.gz/f696794035acc18a0d42229217a9a3b7630d524e"
  

@kevinwhereby
Copy link
Contributor

definitely bundling it though:
image

@thyal
Copy link
Member Author

thyal commented Nov 8, 2023

tested working in the usual suspects

I still see rtcstats in my yalc.lock though... guess we have to publish to really find out

Yeah, not sure. It should be bundling it. Let's publish and try

@thyal thyal merged commit 3d55206 into development Nov 8, 2023
2 checks passed
@thyal thyal deleted the thomas/bundle-rtcstats branch November 8, 2023 11:35
@havardholvik
Copy link
Collaborator

tested working in the usual suspects
I still see rtcstats in my yalc.lock though... guess we have to publish to really find out

Yeah, not sure. It should be bundling it. Let's publish and try

This is expected. One could argue that at this point rtcstats is a devDependency, but lets not worry about this now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants