Add more types to <whereby-embed> web component
#198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havardholvik
force-pushed
the
havard/pan-752-fix-embed-element-typings-to-support-refs
branch
from
62954c3 to
dfd7252
Compare
nandito
approved these changes
Jan 24, 2024
When used in React context, you are now able to get a typed ref when using the web component. The typed ref allows you to listen to and handle events with type safety, and also issue commands in a type-safe manner.
havardholvik
force-pushed
the
havard/pan-752-fix-embed-element-typings-to-support-refs
branch
from
dfd7252 to
bba3a9a
Compare
havardholvik
deleted the
havard/pan-752-fix-embed-element-typings-to-support-refs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When used in React context, you are now able to get a typed ref when using the web component. The typed ref allows you to listen to and handle events with type safety, and also issue commands in a type-safe manner.
Testing
Try the modified Storybook story