Move to esbuild #79
Merged
Move to esbuild #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
3 times, most recently
from
2bb70ec to
6b44ebb
Compare
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
6b44ebb to
bca9773
Compare
|
Hmm it seems the fullly bundled embed build doesn't work... |
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
bca9773 to
343a8f8
Compare
|
@havardholvik got the full embed bundle working, I think we're good to go now |
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
343a8f8 to
38a70b2
Compare
Nice! Im doing some review and testing now, will be done shortly |
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
38a70b2 to
583dddd
Compare
kevinwhereby
commented
Oct 12, 2023
| roomUrl: string, | ||
| roomConnectionOptions: UseRoomConnectionOptions | ||
| ): RoomConnectionRef { | ||
| export function useRoomConnection(roomUrl: string, roomConnectionOptions: UseRoomConnectionOptions): RoomConnectionRef { |
There was a problem hiding this comment.
This default export was causing webpack build errors when importing into a Create React App app.
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
07f72d2 to
60577be
Compare
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
60577be to
f3bbd6a
Compare
|
The react build isn't isolated because for some reason even though the entry point for that builds is specified as |
esbuild doesn't support generating type declarations like rollup doesn This is a little problematic, as now we have a separate build step that tells tsc to generate our types. tsc doesn't support generating a single index.d.ts file for es6 modules, so we emit our directory structure.
kevinwhereby
force-pushed
the
kevinhanna/pan-329-fix-assert-issue
branch
from
f3bbd6a to
106772b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are having some funny module resolution problems with rollup, so this pr aims to replace it with esbuild
Adds build steps for individual react/embed builds as well
Gotchas
Esbuild can't emit typescript declarations, so we have to do it with
tscUnfortunately, tsc can't generate es6 concatenated declarations so we include the full directory structure... is this a problem?
To Test
yarnto install the stuffyarn buildto generate the builds and typesScreenshots
Here's me importing just the react bundle like
import { useRoomConnection } from "@whereby.com/browser-sdk/react"and using the embed bundle in a script tag like
<script type="module" src="./node_modules/@whereby.com/browser-sdk/dist/embed/index.esm.js"></script>