Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handled knocker from the waiting participant list #82

Conversation

nandito
Copy link
Collaborator

@nandito nandito commented Oct 13, 2023

We accidentally removed the waiting_participant_left event listener during a refactor (#68). This caused a bug in the knock handling: whenever a knock got accepted or rejected, it didn't get removed from the waiting participant list.

Test plan

  1. Use a locked room in your sample app
  2. Join with a host who can see and accept/reject waiting participants
  3. Knock the room with a guest => host should see the knocker
  4. Accept the knocker => it should join the room and the waiting participant list should be empty again

@nandito nandito requested review from thyal and kevinwhereby October 13, 2023 08:49
@nandito nandito self-assigned this Oct 13, 2023
@nandito nandito added the bug Something isn't working label Oct 13, 2023
Copy link
Contributor

@kevinwhereby kevinwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@nandito nandito merged commit cb83a76 into development Oct 13, 2023
1 check passed
@nandito nandito deleted the nandor/pan-339-re-add-waiting-participant-left-event-listener branch October 13, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants