Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle native stop screen share #90

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Handle native stop screen share #90

merged 1 commit into from
Oct 20, 2023

Conversation

nandito
Copy link
Collaborator

@nandito nandito commented Oct 19, 2023

Browsers have a native notification to "Stop screen share". Clicking it stops the screen share, but it stays still in the state.

Adding a listener to catch streams' ends should help fix this issue.

Test plan

  1. Open your sdk sample app with 2 clients
  2. Start a screen share with one of them => it should be visible for both clients
  3. Click the browser notification's "stop" button => screen share should stop for both clients properly (without black or frozen frames)
  4. Test it in Chrome, FF, Safari

@nandito
Handle native stop screen shares
554acbd 
The browsers have a native notification to "Stop screen share". Clicking
it stops the screen share, but it stays still in the state.

Adding a listener to catch streams' ends should help fix this issue.
@nandito nandito self-assigned this Oct 19, 2023
thyal
thyal approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@thyal thyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 Works nicely. Tested in Chrome, Firefox and Safari.

@nandito nandito merged commit 71dc20e into development Oct 20, 2023
2 checks passed
@nandito nandito deleted the nandor/pan-341-handle-native-stop-screenshare branch October 20, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thyal thyal thyal approved these changes

@havardholvik havardholvik Awaiting requested review from havardholvik

@kevinwhereby kevinwhereby Awaiting requested review from kevinwhereby

Assignees

@nandito nandito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandito @thyal