Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add externalId as attribute in RoomConnectionOptions #92

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add externalId as attribute in RoomConnectionOptions #92

merged 3 commits into from
Oct 26, 2023

Conversation

jamesdools-whereby
Copy link
Contributor

https://linear.app/whereby/issue/KOA-454/add-externalid-as-an-attribute-for-the-browser-sdk

Related to recent merge in stable release: #89

Adds externalId to embed element and via RoomConnectionOptions.

Test plan

  • Run SDK in a demo-app
  • Add externalId to options in useRoomConnection hook
    eg.
    displayName: "james",
    localMediaConstraints: {
      video: true,
      audio: false,
    },
    logger: console,
    externalId: "jimbob-external-id",
  });
  • Verify externalId is passed through to signal messages.

Screenshots

Screenshot 2023-10-19 at 16 37 46

@jamesdools-whereby jamesdools-whereby changed the base branch from main to development October 19, 2023 15:44
@jamesdools-whereby jamesdools-whereby marked this pull request as ready for review October 19, 2023 15:44
havardholvik
havardholvik approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@havardholvik havardholvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump package.json further 👍

@jamesdools-whereby jamesdools-whereby merged commit ea03459 into development Oct 26, 2023
2 checks passed
@jamesdools-whereby jamesdools-whereby deleted the jamesdooley/koa-454-add-externalid-as-an-attribute-for-the-browser-sdk-v2 branch October 26, 2023 09:25
havardholvik pushed a commit that referenced this pull request Jan 8, 2024
@jamesdools-whereby @havardholvik
Add externalId as attribute in RoomConnectionOptions (#92)
2c1b7c5 
* Add externalId to embed element and RoomConnectionOptions

* v2.0.0-alpha26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havardholvik havardholvik havardholvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdools-whereby @havardholvik