Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and build warnings #96

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

havardholvik
Copy link
Collaborator

A few fixes to fix annoying warnings/errors in the console when testing and building the library. Mainly

  • Remove any types
  • Adjust jest roots
  • Fix incorrect usage of react testing library

@havardholvik havardholvik requested a review from a team October 23, 2023 07:42
Copy link
Contributor

@kevinwhereby kevinwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks sensible to me 👍

We were getting warnings about duplicate mocks as the sample app in some
configurations (yalc) imports the sdk in its entirety. Remove this
warning by setting jest root to src folder.
Although our tests have been green, we were seeing quite a few ugly
errors when running unit tests. Fix these by upgrading our testing
library and make use of the waitFor function to assert state changes.
@havardholvik havardholvik force-pushed the holvik/fix-test-warnings branch from 2cc0fc4 to 30e63bf Compare October 24, 2023 09:22
@havardholvik havardholvik merged commit 3da2fee into development Oct 24, 2023
2 checks passed
@havardholvik havardholvik deleted the holvik/fix-test-warnings branch October 24, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants