Async consumers for multiprocessing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
requested changes
Dec 7, 2021
islandora-support/src/main/java/ca/islandora/alpaca/support/config/PropertyConfig.java
Outdated
Show resolved
Hide resolved
whikloj
reviewed
Dec 7, 2021
| For example, with two services defined (houdini and crayfits) my configuration would have | ||
|
|
||
| ``` | ||
| derivative.systems.installed=houdini,fits | ||
|
|
There was a problem hiding this comment.
This is a total nit-pick but could you add
derivative.houdini.async-consumer=true
below as that one has different values for concurrent-consumers and max-concurrent-consumers.
Otherwise, I'm good with this.
There was a problem hiding this comment.
Heh... could do: Didn't really want to touch the example stuff where it says "[your] configuration would have [these things]"...
whikloj
approved these changes
Dec 8, 2021
whikloj
added a commit
that referenced
this pull request
Dec 10, 2021
* Make a single jar with configurable services * Add example properties * Remove old property files, fix license on classes copied from Fedora * More fixes to README * Fixes from tests not working * Logging for custom http client settings * Alter README * Alter Github Actions to use Java 11 * Make concurrent consumers configurable per service * Add disableStreamCache=true option to http calls * Switch back to using toD with full URL * Missed clean-up * Fix PMD rule violations * Fix GH actions for different branches * Ignore 2 PMD rules in specific cases * Correctly reference the exchange * Move to inject the CamelContext (#1) * Change up instantiation/initialization slightly. * PostConstruct is allowed to apply to private methods... ... seems like a false-positive in PMD? Got example exception from: https://stackoverflow.com/a/48679770 * Changing to camel's 3.7.6 LTS. * Async consumers for multiprocessing (#2) * Fix up warning about the unclosed app context. * Slap together async-consumer stuff. * Add separator for asyncConsumer parameter. * Update example as suggested. * Code review Co-authored-by: Adam <adam-vessey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, bit of formatting of the markdown.
... I need some more complex images to OCR, to be able to see multiple threads... or to slap in JP2 encoding or something that takes longer in terms of a derivative to see multiple
convertinstances running at a time...