Skip to content

Commit

Permalink
Windows test
Browse files Browse the repository at this point in the history
  • Loading branch information
whikloj committed Apr 12, 2024
1 parent cefe7c9 commit 2d04d1a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/v5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
name: PHP ${{ matrix.php-versions }} - OS ${{ matrix.host-os }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand All @@ -38,7 +38,7 @@ jobs:
if: ${{ startsWith( matrix.host-os , 'ubuntu') }}

- name: Cache dependencies (Ubuntu)
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.composercache-ubuntu.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand All @@ -53,7 +53,7 @@ jobs:
if: ${{ startsWith( matrix.host-os , 'windows') }}

- name: Cache dependencies (Windows)
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.composercache-windows.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand All @@ -71,7 +71,7 @@ jobs:
run: composer phpunit

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./clover.xml
fail_ci_if_error: true
Expand Down
2 changes: 2 additions & 0 deletions src/Bag.php
Original file line number Diff line number Diff line change
Expand Up @@ -2186,12 +2186,14 @@ private static function getExtension(string $filepath): ?string
{
$filename = strtolower(basename($filepath));
$pathinfo = pathinfo($filename);
var_dump($pathinfo);
$extensions = [];
$extensions[] = $pathinfo['extension'] ?? null;
while (strpos($pathinfo['filename'], ".") > -1) {
$pathinfo = pathinfo($pathinfo['filename']);
$extensions[] = $pathinfo['extension'] ?? null;
}
var_dump($extensions);
$extensions = array_filter($extensions);
if (count($extensions) > 0) {
return implode(".", array_reverse($extensions));
Expand Down

0 comments on commit 2d04d1a

Please sign in to comment.