Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DockerClickhouseService to facilitate clickhouse integration in docker #152

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

XunGuo1992
Copy link
Contributor

@XunGuo1992 XunGuo1992 commented Dec 22, 2023

What type of PR is this

  • new feature

What this PR does / why we need it

  • Clickhouse is a fast open-source column-oriented database management system. This PR is to add a new type of service : DockerClickhouseService to facilitate docker based clickhouse integration testing in scala.

How to test your code

  • run sbt
  • In sbt run project tests
  • and then run testOnly com.whisk.docker.testkit.test.ClickhouseServiceTest
  • Test passed as follows

[info] ClickhouseServiceTest:
[info] - test container started
[info] Run completed in 12 seconds, 510 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 32 s, completed Dec 22, 2023, 4:51:59 PM

@XunGuo1992
Copy link
Contributor Author

@notxcain Would you please, by any chance, help to review this PR ?

@XunGuo1992
Copy link
Contributor Author

XunGuo1992 commented Jan 9, 2024

@notxcain Thank your for your approval.

Since I don't have write access to this repo, would you please help to merge this PR on behalf of me ?

@notxcain notxcain merged commit 6ad2022 into whisklabs:master Feb 14, 2024
@notxcain
Copy link
Contributor

@XunGuo1992 this was released as part of the version 0.12.0. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants