Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the library run on 1.2.0 and stable #7

Merged
merged 2 commits into from
Nov 10, 2015

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Nov 10, 2015

Relevant for rust-lang/cargo#2127.

@tbu-
Copy link
Contributor Author

tbu- commented Nov 10, 2015

I installed multirust and tested this locally, should work. The tests don't compile on stable/1.2.0.

Fixes the errors reported at https://travis-ci.org/rust-lang/cargo/builds/90258059.

@whitequark
Copy link
Owner

LGTM, do you think you could also update .travis.yml to include stable?

@tbu-
Copy link
Contributor Author

tbu- commented Nov 10, 2015

The tests currently don't compile on stable, should I fix that too?

@tbu-
Copy link
Contributor Author

tbu- commented Nov 10, 2015

@whitequark Tests run on all versions now.

@whitequark
Copy link
Owner

Wonderful, thanks!

whitequark added a commit that referenced this pull request Nov 10, 2015
Make the library run on 1.2.0 and stable
@whitequark whitequark merged commit f96010e into whitequark:master Nov 10, 2015
@whitequark
Copy link
Owner

Released pre5.

@tbu-
Copy link
Contributor Author

tbu- commented Nov 10, 2015

Thanks for responding so quickly all the time! The cargo PR passes all its tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants