-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rust 2021 #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! It looks like clippy is still unhappy: https://github.com/TimTheBig/rust-xdg/actions/runs/9257836687/job/25466781313#step:6:22 |
The main clippy complaint does make the code a lot cleaner so I would consider it: self.state_home.as_ref().map(|home| home.as_path()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using`self.state_home.as_deref()` I can also make clippy ignore it with |
Yeah, let's apply that. |
whitequark
reviewed
May 28, 2024
TimTheBig
commented
May 28, 2024
whitequark
requested changes
May 29, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to Rust 2021 and Refactor
Updates
Rust edition 2018 –> 2021
Version 2.5.2 –> 2.6.0
msrv according to cargo-msrv 1.40.0 –> 1.60.0, tested on x64 and arm64.
Small changes
Added
"xdg"
as keyword incargo.toml
Add Swatinem/rust-cache to
ci.yml
anddocs.yml
for CI speed up.Add CI, Doc-test, msrv and version badges to
README.md
.actions/checkout
v3 –> v4Make lint workflow continue on fmt error, so clippy can also run.