Allow controlling Frosted theme with CustomEvents #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jjantschulev
commented
Dec 11, 2023
jjantschulev
commented
- temporary idea
- Cleaned up PR
Unimported Action reportSummary
|
arturbien
reviewed
Dec 11, 2023
| @@ -259,6 +282,7 @@ const ThemeImpl = React.forwardRef<ThemeImplElement, ThemeImplProps>( | |||
| ], | |||
| )} | |||
| > | |||
| {isRoot && <WithThemeEvents />} | |||
arturbien
reviewed
Dec 11, 2023
arturbien
approved these changes
Dec 11, 2023
Co-authored-by: Artur Bień <artur.bien@gmail.com>
This was referenced Dec 11, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
### General Changes - feat: allow controlling Frosted theme with CustomEvents (#42) ### Credits @jjantschulev
This was referenced Dec 11, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
### General Changes - feat: allow controlling Frosted theme with CustomEvents (#42) - feat: add 'translucent' variant to Popover (#45) ### Credits @jjantschulev, @arturbien
This was referenced Dec 12, 2023
This was referenced Jan 5, 2024
This was referenced Jan 25, 2024
This was referenced Feb 8, 2024
This was referenced Feb 21, 2024
This was referenced Mar 12, 2024
This was referenced Apr 25, 2024
This was referenced Jun 29, 2024
This was referenced Jul 24, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.