Skip to content

Commit

Permalink
Multi org process logger (#1575)
Browse files Browse the repository at this point in the history
We need to support multi org workflows. Currently, the process rolling
logger stores all of its profiles keyed off of the dataset id, assuming
that the global whylabs api key applies to all of them more or less.
Technically, its already possible to create custom writers which are the
only things that know about the org but the logger would end up rolling
data for different orgs into the same profiles if they have same org id.

This change allows you to explicitly pass an org id into the logger
which is used for cached profiles when logging. That in combination with
a custom writer factory gets you to multi org logging.

This also updates some of the types for the most recent pyright version,
despite whylogs not actually depending on that yet.

This does end up having to be a breaking change unfortunately, though
all
of these logger and actor types are still in the experimental namespace.
  • Loading branch information
naddeoa authored Oct 22, 2024
1 parent 2a85ed4 commit a04f37b
Show file tree
Hide file tree
Showing 9 changed files with 224 additions and 148 deletions.
15 changes: 8 additions & 7 deletions python/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ twine = "^4.0.1"
gcp-storage-emulator = "^2022.6.11"
urllib3 = ">=1.25.4, <1.27"
types-requests = "2.30.0.0"
pyright = "^1.1.338"
pyright = "^1.1.383"
httpretty = { version = "^1.1.4", python = ">=3.6,<3.10"}
ruff = "^0.4.4"
pytest-xdist = {version = "^3.6.1", python = ">=3.8,<4"}
Expand Down
Loading

0 comments on commit a04f37b

Please sign in to comment.