-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the v1 version of the log api #1589
Conversation
a74b1cb
to
bc11e6b
Compare
Some of the integration tests are failing. Investigating... |
Some just look like the mocks for injecting throttling need to be adjusted for V1. There are also some transaction test failures I haven't looked at yet. |
There are integration tests failing on mainline too, so maybe some of this is a backend problem. |
@richard-rogers Things are all green now so I guess you reran them? |
The CI doesn't run the integration tests. They're still failing here and on mainline. |
Mainline CI is passing now. I updated the URI mocks, so now only a few transaction tests are failing. |
@richard-rogers can you post the failures or something so I can debug? |
I will investigate them today. You can run them by setting up the |
I think I figured it out. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests are green now
d6150ba
to
64dd527
Compare
This switches from the v0 to the v1 profile upload api, replacing the previous use of log_async in the whylabs client with log_profile. The apis are functionally the same but the dataset id and the org id are specified differently. The dataset id has to be supplied via a different name and ends up as a header in the request, while the org id is not specified at all because its derived from the api key.
In terms of implementation, I tried to do this all from outside of whylogs to avoid having to make this change but there are several issues that pop up when you try to pass in your own
WhylabsClient
, and especially your ownApiClient
that made that impossible. The refactor looks daunting as well.Instead, this change just passes on the
WhylabsClient
to the other "sub writers" that are secretly made in the whylabs writer, and hard codes the use of the v1 api over the v0 api.