Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined variable if get_profile_observatory_link() fails #1590

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix undefined variable if get_profile_observatory_link() fails #1590

merged 2 commits into from
Nov 18, 2024

Conversation

richard-rogers
Copy link
Contributor

Bail out early if get_profile_observatory_link() fails since the rest of the methods require a valid response.

@richard-rogers
Fix undefined variable if get_profile_observatory_link() fails
1a92776 
Bail out early if `get_profile_observatory_link()` fails since the rest of the methods require a valid `response`.
jamie256
jamie256 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richard-rogers richard-rogers merged commit 301453c into mainline Nov 18, 2024
14 checks passed
@richard-rogers richard-rogers deleted the dev/richard/get-link-failure branch November 18, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

@cswarth cswarth Awaiting requested review from cswarth

@naddeoa naddeoa Awaiting requested review from naddeoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-rogers @jamie256